Theaninova/DeviceManager
1
0
Fork 0
mirror of https://github.com/CharaChorder/DeviceManager.git synced 2025-12-12 13:56:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: settings without min/max parse as 0

Browse Source 
fixes #75
This commit is contained in:
Thea Schöbl
2023-12-30 12:50:46 +01:00
parent f2f61f32f2
commit edabf8ec84
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/lib/setting.ts
View File

@@ -7,8 +7,9 @@ export const setting: Action<HTMLInputElement, {id: number; inverse?: number; sc
) {
node.setAttribute("disabled", "")
const type = node.getAttribute("type") as "number" | "checkbox"
const min = Number(node.getAttribute("min"))
const max = Number(node.getAttribute("max"))
const min = node.hasAttribute("min") ? Number(node.getAttribute("min")) : undefined
const max = node.hasAttribute("max") ? Number(node.getAttribute("max")) : undefined
console.log(min, max, "|", id, "|", node.getAttribute("min"), node.getAttribute("max"))
const unsubscribe = settings.subscribe(async settings => {
if (id in settings) {
@@ -39,8 +40,8 @@ export const setting: Action<HTMLInputElement, {id: number; inverse?: number; sc
value = Math.floor(
inverse !== undefined ? inverse / value : scale !== undefined ? value / scale : value,
)
if (!Number.isNaN(min)) value = Math.max(min, value)
if (!Number.isNaN(max)) value = Math.min(max, value)
if (min !== undefined) value = Math.max(min, value)
if (max !== undefined) value = Math.min(max, value)
} else {
value = node.checked ? 1 : 0
}