From edabf8ec84c8432fbeced877e4dafe09dd211fb0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thea=20Sch=C3=B6bl?= <dev@theaninova.de>
Date: Sat, 30 Dec 2023 12:50:46 +0100
Subject: [PATCH] fix: settings without min/max parse as 0

fixes #75
---
 src/lib/setting.ts | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/lib/setting.ts b/src/lib/setting.ts
index d891e379..74f2d480 100644
--- a/src/lib/setting.ts
+++ b/src/lib/setting.ts
@@ -7,8 +7,9 @@ export const setting: Action<HTMLInputElement, {id: number; inverse?: number; sc
 ) {
   node.setAttribute("disabled", "")
   const type = node.getAttribute("type") as "number" | "checkbox"
-  const min = Number(node.getAttribute("min"))
-  const max = Number(node.getAttribute("max"))
+  const min = node.hasAttribute("min") ? Number(node.getAttribute("min")) : undefined
+  const max = node.hasAttribute("max") ? Number(node.getAttribute("max")) : undefined
+  console.log(min, max, "|", id, "|", node.getAttribute("min"), node.getAttribute("max"))
 
   const unsubscribe = settings.subscribe(async settings => {
     if (id in settings) {
@@ -39,8 +40,8 @@ export const setting: Action<HTMLInputElement, {id: number; inverse?: number; sc
       value = Math.floor(
         inverse !== undefined ? inverse / value : scale !== undefined ? value / scale : value,
       )
-      if (!Number.isNaN(min)) value = Math.max(min, value)
-      if (!Number.isNaN(max)) value = Math.min(max, value)
+      if (min !== undefined) value = Math.max(min, value)
+      if (max !== undefined) value = Math.min(max, value)
     } else {
       value = node.checked ? 1 : 0
     }