Theaninova/openstapps
1
0
Fork 0
mirror of https://gitlab.com/openstapps/openstapps.git synced 2026-01-21 00:52:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: remove refresher from data detail view

Browse Source
This commit is contained in:
Rainer Killinger
2022-04-05 14:04:25 +00:00
committed by Jovan Krunić
parent d2a23e581e
commit fd7f664792
6 changed files with 2 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/app/modules/hebis/daia-availability/daia-availability.component.spec.ts
View File

@@ -17,7 +17,6 @@
import {CUSTOM_ELEMENTS_SCHEMA} from '@angular/core';
import {ComponentFixture, TestBed} from '@angular/core/testing';
import {ActivatedRoute, RouterModule} from '@angular/router';
import {IonRefresher} from '@ionic/angular';
import {
TranslateLoader,
TranslateModule,
@@ -45,7 +44,6 @@ describe('DaiaAvailabilityComponent', () => {
let comp: DaiaAvailabilityComponent;
let fixture: ComponentFixture<DaiaAvailabilityComponent>;
let dataProvider: DaiaDataProvider;
let refresher: IonRefresher;
const sampleThing = sampleThingsMap.book[0];
let translateService: TranslateService;
let configProviderMock: jasmine.SpyObj<ConfigProvider>;
@@ -114,7 +112,6 @@ describe('DaiaAvailabilityComponent', () => {
const workingDAIAurl = 'https://daia.hebis.de/DAIA2/UB_Frankfurt';
dataProvider.daiaServiceUrl = workingDAIAurl;
translateService = TestBed.inject(TranslateService);
refresher = jasmine.createSpyObj('refresher', ['complete']);
spyOn(dataProvider, 'getAvailability' as any).and.returnValue(
Promise.resolve(sampleThing),
);
@@ -143,12 +140,4 @@ describe('DaiaAvailabilityComponent', () => {
DaiaAvailabilityComponent.prototype.getAvailability,
).toHaveBeenCalledWith(sampleThing.uid);
});
it('should update the data item when refresh is called', async () => {
await comp.refresh(refresher);
expect(
DaiaAvailabilityComponent.prototype.getAvailability,
).toHaveBeenCalledWith(sampleThing.uid);
expect(refresher.complete).toHaveBeenCalled();
});
});

12
src/app/modules/hebis/hebis-detail/hebis-detail.component.spec.ts
View File

@@ -18,7 +18,6 @@
import {CUSTOM_ELEMENTS_SCHEMA} from '@angular/core';
import {ComponentFixture, TestBed} from '@angular/core/testing';
import {ActivatedRoute, RouterModule} from '@angular/router';
import {IonRefresher} from '@ionic/angular';
import {
TranslateLoader,
TranslateModule,
@@ -44,7 +43,6 @@ describe('HebisDetailComponent', () => {
let comp: HebisDetailComponent;
let fixture: ComponentFixture<HebisDetailComponent>;
let dataProvider: HebisDataProvider;
let refresher: IonRefresher;
const sampleThing = sampleThingsMap.book[0];
let translateService: TranslateService;
@@ -98,7 +96,6 @@ describe('HebisDetailComponent', () => {
beforeEach(() => {
dataProvider = TestBed.inject(HebisDataProvider);
translateService = TestBed.inject(TranslateService);
refresher = jasmine.createSpyObj('refresher', ['complete']);
spyOn(dataProvider, 'get' as any).and.returnValue(
Promise.resolve(sampleThing),
);
@@ -126,13 +123,4 @@ describe('HebisDetailComponent', () => {
false,
);
});
it('should update the data item when refresh is called', async () => {
await comp.refresh(refresher);
expect(HebisDetailComponent.prototype.getItem).toHaveBeenCalledWith(
sampleThing.uid,
true,
);
expect(refresher.complete).toHaveBeenCalled();
});
});

8
src/app/modules/hebis/hebis-detail/hebis-detail.html
View File

@@ -14,14 +14,6 @@
</ion-toolbar>
</ion-header>
<ion-content class="ion-no-padding">
<ion-refresher slot="fixed" (ionRefresh)="refresh($event.target)">
<ion-refresher-content
pullingIcon="chevron-down-outline"
pullingText="{{ 'data.REFRESH_ACTION' | translate }}"
refreshingText="{{ 'data.REFRESHING' | translate }}"
>
</ion-refresher-content>
</ion-refresher>
<div [ngSwitch]="true">
<ng-container *ngSwitchCase="!item && isDisconnected | async">
<div class="notFoundContainer">