diff --git a/src/app/modules/data/detail/data-detail.component.spec.ts b/src/app/modules/data/detail/data-detail.component.spec.ts index 8714c1cc..d260a78d 100644 --- a/src/app/modules/data/detail/data-detail.component.spec.ts +++ b/src/app/modules/data/detail/data-detail.component.spec.ts @@ -17,7 +17,7 @@ import {CUSTOM_ELEMENTS_SCHEMA, DebugElement} from '@angular/core'; import {ComponentFixture, TestBed} from '@angular/core/testing'; import {ActivatedRoute, RouterModule} from '@angular/router'; -import {IonRefresher, IonTitle} from '@ionic/angular'; +import {IonTitle} from '@ionic/angular'; import { TranslateLoader, TranslateModule, @@ -45,7 +45,6 @@ describe('DataDetailComponent', () => { let fixture: ComponentFixture; let detailPage: DebugElement; let dataProvider: DataProvider; - let refresher: IonRefresher; const sampleThing = sampleThingsMap.message[0]; let translateService: TranslateService; @@ -99,7 +98,6 @@ describe('DataDetailComponent', () => { beforeEach(() => { dataProvider = TestBed.inject(DataProvider); translateService = TestBed.inject(TranslateService); - refresher = jasmine.createSpyObj('refresher', ['complete']); spyOn(dataProvider, 'get' as any).and.returnValue( Promise.resolve(sampleThing), ); @@ -133,13 +131,4 @@ describe('DataDetailComponent', () => { false, ); }); - - it('should update the data item when refresh is called', async () => { - await comp.refresh(refresher); - expect(DataDetailComponent.prototype.getItem).toHaveBeenCalledWith( - sampleThing.uid, - true, - ); - expect(refresher.complete).toHaveBeenCalled(); - }); }); diff --git a/src/app/modules/data/detail/data-detail.component.ts b/src/app/modules/data/detail/data-detail.component.ts index 38212d83..092350c6 100644 --- a/src/app/modules/data/detail/data-detail.component.ts +++ b/src/app/modules/data/detail/data-detail.component.ts @@ -21,7 +21,7 @@ import { TemplateRef, } from '@angular/core'; import {ActivatedRoute} from '@angular/router'; -import {IonRefresher, ViewWillEnter, ModalController} from '@ionic/angular'; +import {ViewWillEnter, ModalController} from '@ionic/angular'; import {LangChangeEvent, TranslateService} from '@ngx-translate/core'; import { SCLanguageCode, @@ -171,16 +171,4 @@ export class DataDetailComponent implements ViewWillEnter { }); } } - - /** - * Updates the shown thing - * - * @param refresher Refresher component that triggers the update - */ - async refresh(refresher: IonRefresher) { - if (!this.inputItem) { - await this.getItem(this.route.snapshot.paramMap.get('uid') ?? '', true); - } - await refresher.complete(); - } } diff --git a/src/app/modules/data/detail/data-detail.html b/src/app/modules/data/detail/data-detail.html index 77f19078..0c7be63e 100644 --- a/src/app/modules/data/detail/data-detail.html +++ b/src/app/modules/data/detail/data-detail.html @@ -20,14 +20,6 @@ - - - -
diff --git a/src/app/modules/hebis/daia-availability/daia-availability.component.spec.ts b/src/app/modules/hebis/daia-availability/daia-availability.component.spec.ts index c912a596..a634be0f 100644 --- a/src/app/modules/hebis/daia-availability/daia-availability.component.spec.ts +++ b/src/app/modules/hebis/daia-availability/daia-availability.component.spec.ts @@ -17,7 +17,6 @@ import {CUSTOM_ELEMENTS_SCHEMA} from '@angular/core'; import {ComponentFixture, TestBed} from '@angular/core/testing'; import {ActivatedRoute, RouterModule} from '@angular/router'; -import {IonRefresher} from '@ionic/angular'; import { TranslateLoader, TranslateModule, @@ -45,7 +44,6 @@ describe('DaiaAvailabilityComponent', () => { let comp: DaiaAvailabilityComponent; let fixture: ComponentFixture; let dataProvider: DaiaDataProvider; - let refresher: IonRefresher; const sampleThing = sampleThingsMap.book[0]; let translateService: TranslateService; let configProviderMock: jasmine.SpyObj; @@ -114,7 +112,6 @@ describe('DaiaAvailabilityComponent', () => { const workingDAIAurl = 'https://daia.hebis.de/DAIA2/UB_Frankfurt'; dataProvider.daiaServiceUrl = workingDAIAurl; translateService = TestBed.inject(TranslateService); - refresher = jasmine.createSpyObj('refresher', ['complete']); spyOn(dataProvider, 'getAvailability' as any).and.returnValue( Promise.resolve(sampleThing), ); @@ -143,12 +140,4 @@ describe('DaiaAvailabilityComponent', () => { DaiaAvailabilityComponent.prototype.getAvailability, ).toHaveBeenCalledWith(sampleThing.uid); }); - - it('should update the data item when refresh is called', async () => { - await comp.refresh(refresher); - expect( - DaiaAvailabilityComponent.prototype.getAvailability, - ).toHaveBeenCalledWith(sampleThing.uid); - expect(refresher.complete).toHaveBeenCalled(); - }); }); diff --git a/src/app/modules/hebis/hebis-detail/hebis-detail.component.spec.ts b/src/app/modules/hebis/hebis-detail/hebis-detail.component.spec.ts index 51de1074..7d18b3e9 100644 --- a/src/app/modules/hebis/hebis-detail/hebis-detail.component.spec.ts +++ b/src/app/modules/hebis/hebis-detail/hebis-detail.component.spec.ts @@ -18,7 +18,6 @@ import {CUSTOM_ELEMENTS_SCHEMA} from '@angular/core'; import {ComponentFixture, TestBed} from '@angular/core/testing'; import {ActivatedRoute, RouterModule} from '@angular/router'; -import {IonRefresher} from '@ionic/angular'; import { TranslateLoader, TranslateModule, @@ -44,7 +43,6 @@ describe('HebisDetailComponent', () => { let comp: HebisDetailComponent; let fixture: ComponentFixture; let dataProvider: HebisDataProvider; - let refresher: IonRefresher; const sampleThing = sampleThingsMap.book[0]; let translateService: TranslateService; @@ -98,7 +96,6 @@ describe('HebisDetailComponent', () => { beforeEach(() => { dataProvider = TestBed.inject(HebisDataProvider); translateService = TestBed.inject(TranslateService); - refresher = jasmine.createSpyObj('refresher', ['complete']); spyOn(dataProvider, 'get' as any).and.returnValue( Promise.resolve(sampleThing), ); @@ -126,13 +123,4 @@ describe('HebisDetailComponent', () => { false, ); }); - - it('should update the data item when refresh is called', async () => { - await comp.refresh(refresher); - expect(HebisDetailComponent.prototype.getItem).toHaveBeenCalledWith( - sampleThing.uid, - true, - ); - expect(refresher.complete).toHaveBeenCalled(); - }); }); diff --git a/src/app/modules/hebis/hebis-detail/hebis-detail.html b/src/app/modules/hebis/hebis-detail/hebis-detail.html index d6b63d7c..75859e20 100644 --- a/src/app/modules/hebis/hebis-detail/hebis-detail.html +++ b/src/app/modules/hebis/hebis-detail/hebis-detail.html @@ -14,14 +14,6 @@ - - - -