refactor: make feedback protocol data optional

Closes #356
This commit is contained in:
Jovan Krunić
2023-01-13 11:31:43 +00:00
committed by Rainer Killinger
parent cd19cf5b92
commit 63bb1967e1
4 changed files with 44 additions and 13 deletions

View File

@@ -74,6 +74,11 @@ export class FeedbackPageComponent {
*/
termsAgree = false;
/**
* Providing of protocol data accepted or not
*/
protocolDataAgree = false;
/**
* Show meta data or not
*/
@@ -103,8 +108,17 @@ export class FeedbackPageComponent {
const feedbackRequest: SCFeedbackRequest = {
...this.message,
metaData: this.metaData,
metaData: {
platform: '',
scope: {},
state: {},
userAgent: '',
version: '',
},
};
if (this.protocolDataAgree) {
feedbackRequest.metaData = this.metaData;
}
try {
await this.dataProvider.sendFeedback(feedbackRequest);

View File

@@ -67,9 +67,13 @@
></ion-textarea>
</ion-item>
<ion-item>
<ion-label class="ion-text-wrap">{{
'feedback.form.termsAgree' | translate
}}</ion-label>
<ion-label class="ion-text-wrap"
>{{ 'feedback.form.termsAgree.0' | translate }}
<a [routerLink]="['/about/privacy']">{{
'feedback.form.termsAgree.1' | translate
}}</a
>.</ion-label
>
<ion-checkbox
color="primary"
slot="start"
@@ -77,13 +81,17 @@
name="termsAgree"
></ion-checkbox>
</ion-item>
<ion-button
type="submit"
color="primary"
expand="block"
[disabled]="!feedbackForm.valid || !termsAgree || submitSuccess"
>{{ 'feedback.form.submit' | translate }}</ion-button
>
<ion-item>
<ion-label class="ion-text-wrap">{{
'feedback.form.protocolDataAgree' | translate
}}</ion-label>
<ion-checkbox
color="primary"
slot="start"
[(ngModel)]="protocolDataAgree"
name="protocolDataAgree"
></ion-checkbox>
</ion-item>
<ion-card>
<ion-card-title>
<ion-button expand="block" fill="clear" (click)="toggleShowMetaData()">
@@ -99,5 +107,12 @@
<pre>{{ metaData | json }}</pre>
</ion-card-content>
</ion-card>
<ion-button
type="submit"
color="primary"
expand="block"
[disabled]="!feedbackForm.valid || !termsAgree || submitSuccess"
>{{ 'feedback.form.submit' | translate }}</ion-button
>
</form>
</ion-content>

View File

@@ -207,7 +207,8 @@
"label": "Nachricht",
"placeholder": "Deine Nachricht an uns... (minimal {{number}} Zeichen lang)"
},
"termsAgree": "Ich bin damit einverstanden, dass Protokolldaten zur Nachverfolgbarkeit von Fehlern mitversandt werden. Es erfolgt keine Weitergabe dieser Daten an Dritte.",
"termsAgree": ["Hiermit bestätige ich, dass ich die Datenschutzerklärung gelesen habe und ihnen zustimme.", "Hier geht es zu unserer Datenschutzerklärung"],
"protocolDataAgree": "Ich bin damit einverstanden, dass die folgenden Protokolldaten zur Nachverfolgbarkeit von Fehlern mitversandt werden. Es erfolgt keine Weitergabe dieser Daten an Dritte.",
"submit": "Absenden",
"protocolData": {
"show": "Protokolldaten einblenden",

View File

@@ -207,7 +207,8 @@
"label": "Message",
"placeholder": "Your message for us... (minimum {{number}} characters)"
},
"termsAgree": "I agree to provide the protocol data for easier traceability of errors. The data will not be forwarded to any third parties.",
"termsAgree": ["I hereby confirm that I have read and agree to the terms of privacy policy.", "Here you can find our privacy policy"],
"protocolDataAgree": "I agree to provide the following protocol data for easier traceability of errors. The data will not be forwarded to any third parties.",
"submit": "Submit",
"protocolData": {
"show": "Show protocol data",