From fdee2db8a42b8f6c99c4a72b3104ae0ba1a41c5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jovan=20Kruni=C4=87?= Date: Tue, 1 Nov 2022 15:40:47 +0100 Subject: [PATCH] fix: prevent opening invalid links Closes #328 --- src/app/modules/data/elements/external-link.component.ts | 3 ++- .../data/types/message/message-detail-content.component.ts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/app/modules/data/elements/external-link.component.ts b/src/app/modules/data/elements/external-link.component.ts index 108d8205..454d2708 100644 --- a/src/app/modules/data/elements/external-link.component.ts +++ b/src/app/modules/data/elements/external-link.component.ts @@ -29,6 +29,7 @@ export class ExternalLinkComponent { constructor(private browser: Browser) {} onLinkClick(url: string) { - this.browser.open(url); + // make sure if the url is valid and then open it in the browser (prevent problem in iOS) + this.browser.open(new URL(url).href); } } diff --git a/src/app/modules/data/types/message/message-detail-content.component.ts b/src/app/modules/data/types/message/message-detail-content.component.ts index 9b0bd999..a2ca9342 100644 --- a/src/app/modules/data/types/message/message-detail-content.component.ts +++ b/src/app/modules/data/types/message/message-detail-content.component.ts @@ -38,6 +38,7 @@ export class MessageDetailContentComponent { * @param url Web address to open */ onLinkClick(url: string) { - this.browser.open(url); + // make sure if the url is valid and then open it in the browser (prevent problem in iOS) + this.browser.open(new URL(url).href); } }