From e78496fb8ba2da7257202e23af6766a8882f656f Mon Sep 17 00:00:00 2001 From: Rainer Killinger Date: Thu, 10 Feb 2022 15:19:06 +0100 Subject: [PATCH] refactor: read android secrets from environment --- app.conf.sample | 18 ++++++++++++------ static/fastlane-android/Fastfile | 8 ++++---- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/app.conf.sample b/app.conf.sample index 3e56fd8e..95b5e37d 100644 --- a/app.conf.sample +++ b/app.conf.sample @@ -7,17 +7,23 @@ BACKEND_VERSION="2.0.0" # Minimum backend version th APP_LINK_HOST="your.deep.link.host.tld" # Your host used for universal (deep) links APP_URL_SCHEME="de.anyschool.app" # Custom url scheme for native app versions -# Android specific configuration - -ANDROID_PACKAGE_NAME="de.anyschool.app.droid" # e.g. com.krausefx.app - # iOS specific sonfiguration -LOCATION_USAGE_DESCRIPTION="Die Ortungsdienste werden für die Kartenansichten und bessere Suchergebnisse benötigt" +LOCATION_USAGE_DESCRIPTION="Ortungsdienste werden für die Kartenansichten und bessere Suchergebnisse benötigt" CALENDAR_USAGE_DESCRIPTION="Zugriff auf Kalender wird für die Synchronisierung deiner Uni Termine benötigt" IOS_BUNDLE_IDENTIFIER="com.anyschool.app.ios" # The bundle identifier of your ios app APPLE_ID="example@domain.tld" # Your Apple Developer email address ITC_TEAM_ID="123412345" # App Store Connect Team ID TEAM_ID="ABCDEV1234" # Developer Team ID -PROVISIONING_PROFILE_NAME="App Deployment Profile" # Name of the apps own provisioning profile used for signing + + +# Android specific configuration + +ANDROID_PACKAGE_NAME="de.anyschool.app.android" # Your Google Playconsole app package name + +# Provide the following environment variables in a secure fashion. +# Don't change the following lines! +ANDROID_KEYSTORE_PASSWORD="${ANDROID_KEYSTORE_PASSWORD:-'unsed'}" # Passwort to your keyfile +ANDROID_KEYSTORE_KEY_ALIAS="${ANDROID_KEYSTORE_KEY_ALIAS:-'unsed'}" # Name/Alias of the key used for signing within the keyfile +ANDROID_KEYSTORE_KEY_PASSWORD="${ANDROID_KEYSTORE_KEY_PASSWORD:-'unsed'}" # Passwort to the this very key diff --git a/static/fastlane-android/Fastfile b/static/fastlane-android/Fastfile index 55b6133e..a252a25d 100644 --- a/static/fastlane-android/Fastfile +++ b/static/fastlane-android/Fastfile @@ -41,10 +41,10 @@ platform :android do build_type: "Release", print_command: false, properties: { - "android.injected.signing.store.file" => "../../../playstore.keystore", - "android.injected.signing.store.password" => "", - "android.injected.signing.key.alias" => "", - "android.injected.signing.key.password" => "", + "android.injected.signing.store.file" => "/build/playstore.keystore", + "android.injected.signing.store.password" => ENV['ANDROID_KEYSTORE_PASSWORD'], + "android.injected.signing.key.alias" => ENV['ANDROID_KEYSTORE_KEY_ALIAS'], + "android.injected.signing.key.password" => ENV['ANDROID_KEYSTORE_KEY_PASSWORD'], "versionCode" => version_code, "versionName" => package_json['version'] }