diff --git a/frontend/app/src/app/modules/profile/id-cards.provider.ts b/frontend/app/src/app/modules/profile/id-cards.provider.ts index 0758a810..8f56d42f 100644 --- a/frontend/app/src/app/modules/profile/id-cards.provider.ts +++ b/frontend/app/src/app/modules/profile/id-cards.provider.ts @@ -38,13 +38,12 @@ export class IdCardsProvider { } private fetchIdCards(url: string, token: string): Observable { - // eslint-disable-next-line unicorn/no-null - return this.httpClient.post(url, null, { + return this.httpClient.get(url, { headers: { Authorization: `Bearer ${token}`, }, responseType: 'json', - }) as Observable; + }); } private fetchFallbackIdCards(user: SCUserConfiguration): Observable { diff --git a/frontend/app/src/app/modules/profile/id-cards.spec.ts b/frontend/app/src/app/modules/profile/id-cards.spec.ts index 5db6b24d..2c3fd398 100644 --- a/frontend/app/src/app/modules/profile/id-cards.spec.ts +++ b/frontend/app/src/app/modules/profile/id-cards.spec.ts @@ -23,7 +23,7 @@ describe('IdCards', () => { configProvider.config = { app: {features: {extern: {idCards: {url: 'http://id-cards.local', authProvider: 'fakeAuth'}}}}, } as never; - httpClient = jasmine.createSpyObj('HttpClient', ['post']); + httpClient = jasmine.createSpyObj('HttpClient', ['get']); fakeAuth = new FakeAuth(); authHelper = jasmine.createSpyObj('AuthHelperService', ['getProvider']); authHelper.getProvider = jasmine.createSpy().and.returnValue(fakeAuth); @@ -37,15 +37,15 @@ describe('IdCards', () => { it('should emit network result when logged in', async () => { fakeAuth.isAuthenticated$.next(true); - httpClient.post = jasmine.createSpy().and.returnValue(of(['abc'])); + httpClient.get = jasmine.createSpy().and.returnValue(of(['abc'])); fakeAuth.getValidToken = jasmine.createSpy().and.resolveTo({accessToken: 'fake-token'}); const provider = new IdCardsProvider(authHelper, configProvider, httpClient); expect(await firstValueFrom(provider.getIdCards())).toEqual(['abc' as never]); expect(authHelper.getProvider).toHaveBeenCalledOnceWith('fakeAuth' as SCAuthorizationProviderType); // eslint-disable-next-line unicorn/no-null - expect(httpClient.post).toHaveBeenCalledOnceWith('http://id-cards.local', null, { + expect(httpClient.get).toHaveBeenCalledOnceWith('http://id-cards.local', { headers: { - Authorization: 'Bearer: fake-token', + Authorization: 'Bearer fake-token', }, responseType: 'json', }); @@ -55,7 +55,7 @@ describe('IdCards', () => { const provider = new IdCardsProvider(authHelper, configProvider, httpClient); const observable = provider.getIdCards(); expect(await firstValueFrom(observable)).toEqual([]); - httpClient.post = jasmine.createSpy().and.returnValue(of(['abc'])); + httpClient.get = jasmine.createSpy().and.returnValue(of(['abc'])); fakeAuth.getValidToken = jasmine.createSpy().and.resolveTo({accessToken: 'fake-token'}); fakeAuth.isAuthenticated$.next(true); // this is counter-intuitive, but because we unsubscribed above the first value