refactor: use reviewer assigning of gitlab 13.2

This commit is contained in:
Rainer Killinger
2021-02-15 11:54:20 +01:00
parent 2796fd8ec9
commit e17bfa9d77

View File

@@ -120,6 +120,9 @@ export async function remind(api: Api): Promise<void> {
if (mergeRequest.assignee.username === username) { if (mergeRequest.assignee.username === username) {
return false; return false;
} }
if (mergeRequest.assignee.username.includes('openstapps')) {
return false;
}
if (approval.approved_by.length === 0) { if (approval.approved_by.length === 0) {
return true; return true;
@@ -135,7 +138,7 @@ export async function remind(api: Api): Promise<void> {
}); });
}) })
.map((username) => `@${username}`) .map((username) => `@${username}`)
.join(', '); .join(' ');
// send message to slack // send message to slack
await client?.chat.postMessage({ await client?.chat.postMessage({
@@ -143,13 +146,14 @@ export async function remind(api: Api): Promise<void> {
text: `Merge request '${mergeRequest.title}' needs more approvals! See ${mergeRequest.web_url}!`, text: `Merge request '${mergeRequest.title}' needs more approvals! See ${mergeRequest.web_url}!`,
}); });
// create note in merge request // assign reviewers
await api.createNote( await api.createNote(
mergeRequest.project_id, mergeRequest.project_id,
Scope.MERGE_REQUESTS, Scope.MERGE_REQUESTS,
mergeRequest.iid, mergeRequest.iid,
`${NOTE_PREFIX} Please review, ${possibleApprovers}!`, `/assign_reviewer ${possibleApprovers}`,
); );
} else { } else {
Logger.log(`Merge request '${mergeRequest.title}' is ready to be merged!`); Logger.log(`Merge request '${mergeRequest.title}' is ready to be merged!`);