From cfb4aa364f7ca54efe6cea2d9561be22936979bb Mon Sep 17 00:00:00 2001
From: Rainer Killinger <killinger@hrz.uni-frankfurt.de>
Date: Tue, 28 Nov 2023 11:32:03 +0100
Subject: [PATCH] refactor: add new book and periodical categories

---
 packages/core/src/things/book.ts       | 3 +++
 packages/core/src/things/periodical.ts | 8 +++++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/packages/core/src/things/book.ts b/packages/core/src/things/book.ts
index 075678e5..78b9ff38 100644
--- a/packages/core/src/things/book.ts
+++ b/packages/core/src/things/book.ts
@@ -51,6 +51,7 @@ export type SCBookCategories =
   | 'manuscript'
   | 'map'
   | 'microfilm'
+  | 'mixed_material'
   | 'musicalscore'
   | 'photo'
   | 'physicalobject'
@@ -180,6 +181,7 @@ export class SCBookMeta extends SCThingMeta implements SCMetaTranslations<SCBook
         manuscript: 'Handschrift',
         map: 'Karte',
         microfilm: 'Mikrofilm, Mikrofiche',
+        mixed_material: 'Gemischte Materialien',
         musicalscore: 'Noten',
         photo: 'Abbildung',
         physicalobject: 'Objekt',
@@ -212,6 +214,7 @@ export class SCBookMeta extends SCThingMeta implements SCMetaTranslations<SCBook
         manuscript: 'manuscript',
         map: 'map',
         microfilm: 'microfilm, microfiche',
+        mixed_material: 'mixed material',
         musicalscore: 'sheet music',
         photo: 'illustration',
         physicalobject: 'object',
diff --git a/packages/core/src/things/periodical.ts b/packages/core/src/things/periodical.ts
index 36bff0af..91068026 100644
--- a/packages/core/src/things/periodical.ts
+++ b/packages/core/src/things/periodical.ts
@@ -37,7 +37,7 @@ import {
 /**
  * Categories of a periodical
  */
-export type SCPeriodicalCategories = 'journal' | 'electronic';
+export type SCPeriodicalCategories = 'eJournal' | 'electronic' | 'journal';
 
 /**
  * A periodical without references
@@ -139,7 +139,8 @@ export class SCPeriodicalMeta extends SCThingMeta implements SCMetaTranslations<
       ...new SCThingThatCanBeOfferedMeta<SCAcademicPriceGroup>().fieldValueTranslations.de,
       type: 'Periodikum',
       categories: {
-        electronic: 'E-Journal',
+        eJournal: 'E-Journal',
+        electronic: 'Elektronische Ressource',
         journal: 'Zeitschrift',
       },
     },
@@ -152,7 +153,8 @@ export class SCPeriodicalMeta extends SCThingMeta implements SCMetaTranslations<
       ...new SCThingThatCanBeOfferedMeta<SCAcademicPriceGroup>().fieldValueTranslations.en,
       type: 'periodical',
       categories: {
-        electronic: 'E-Journal',
+        eJournal: 'E-Journal',
+        electronic: 'electronic resource',
         journal: 'journal',
       },
     },