fix: feedback not allowing valid emails

Closes #349
This commit is contained in:
Jovan Krunić
2022-12-15 11:56:41 +01:00
parent f55f3ae518
commit cf74c8e19f
4 changed files with 16 additions and 7 deletions

View File

@@ -31,6 +31,11 @@ import {TranslateService} from '@ngx-translate/core';
styleUrls: ['./feedback-page.scss'], styleUrls: ['./feedback-page.scss'],
}) })
export class FeedbackPageComponent { export class FeedbackPageComponent {
/**
* Minimum allowed size of the feedback message
*/
MINIMUM_MESSAGE_SIZE = 15;
constructor( constructor(
private readonly dataProvider: DataProvider, private readonly dataProvider: DataProvider,
private readonly debugDataCollector: DebugDataCollectorService, private readonly debugDataCollector: DebugDataCollectorService,

View File

@@ -46,7 +46,8 @@
[(ngModel)]="author.email" [(ngModel)]="author.email"
type="email" type="email"
name="email" name="email"
pattern="[A-Za-z0-9._%+-]{3,}@[a-zA-Z]{3,}([.]{1}[a-zA-Z]{2,}|[.]{1}[a-zA-Z]{2,}[.]{1}[a-zA-Z]{2,})" ngModel
email
></ion-input> ></ion-input>
</ion-item> </ion-item>
<ion-item> <ion-item>
@@ -55,10 +56,13 @@
}}</ion-label> }}</ion-label>
<ion-textarea <ion-textarea
[(ngModel)]="message.messageBody" [(ngModel)]="message.messageBody"
placeholder="{{ 'feedback.form.message.placeholder' | translate }}" placeholder="{{
'feedback.form.message.placeholder'
| translate: {number: MINIMUM_MESSAGE_SIZE}
}}"
name="message" name="message"
required="true" required="true"
minlength="30" minlength="{{ MINIMUM_MESSAGE_SIZE }}"
autoGrow="true" autoGrow="true"
></ion-textarea> ></ion-textarea>
</ion-item> </ion-item>

View File

@@ -201,11 +201,11 @@
}, },
"email": { "email": {
"label": "E-Mail", "label": "E-Mail",
"placeholder": "deine@mailadresse.de" "placeholder": "deine@mailadresse"
}, },
"message": { "message": {
"label": "Nachricht", "label": "Nachricht",
"placeholder": "Deine Nachricht an uns..." "placeholder": "Deine Nachricht an uns... (minimal {{number}} Zeichen lang)"
}, },
"termsAgree": "Ich bin damit einverstanden, dass Protokolldaten zur Nachverfolgbarkeit von Fehlern mitversandt werden. Es erfolgt keine Weitergabe dieser Daten an Dritte.", "termsAgree": "Ich bin damit einverstanden, dass Protokolldaten zur Nachverfolgbarkeit von Fehlern mitversandt werden. Es erfolgt keine Weitergabe dieser Daten an Dritte.",
"submit": "Absenden", "submit": "Absenden",

View File

@@ -201,11 +201,11 @@
}, },
"email": { "email": {
"label": "Mail", "label": "Mail",
"placeholder": "your@mailaddress.com" "placeholder": "your@mailaddress"
}, },
"message": { "message": {
"label": "Message", "label": "Message",
"placeholder": "Your message for us..." "placeholder": "Your message for us... (minimum {{number}} characters)"
}, },
"termsAgree": "I agree to provide the protocol data for easier traceability of errors. The data will not be forwarded to any third parties.", "termsAgree": "I agree to provide the protocol data for easier traceability of errors. The data will not be forwarded to any third parties.",
"submit": "Submit", "submit": "Submit",