feat: update to of elasticsearch 8.4

test/storage/elasticsearch/aggregations.spec.ts

@@ -13,13 +13,13 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
+import {AggregateName, AggregationsMultiTermsBucket} from '@elastic/elasticsearch/lib/api/types';
 import {SCFacet, SCThingType} from '@openstapps/core';
 import {expect} from 'chai';
 import {parseAggregations} from '../../../src/storage/elasticsearch/aggregations';
-import {AggregationResponse} from '../../../src/storage/elasticsearch/types/elasticsearch';
 
 describe('Aggregations', function () {
-  const aggregations: AggregationResponse = {
+  const aggregations: Record<AggregateName, Partial<AggregationsMultiTermsBucket>> = {
     'catalog': {
       'doc_count': 4,
       'superCatalogs.categories': {
@@ -76,14 +76,6 @@ describe('Aggregations', function () {
         buckets: [],
       },
     },
-    'fooType': {
-      buckets: [
-        {
-          doc_count: 321,
-          key: 'foo',
-        },
-      ],
-    },
     '@all': {
       doc_count: 17,
       type: {
@@ -102,33 +94,6 @@ describe('Aggregations', function () {
   };
 
   const expectedFacets: SCFacet[] = [
-    {
-      buckets: [
-        {
-          count: 13,
-          key: 'person',
-        },
-        {
-          count: 4,
-          key: 'catalog',
-        },
-      ],
-      field: 'type',
-    },
-    {
-      buckets: [
-        {
-          count: 8,
-          key: 'foobar',
-        },
-        {
-          count: 2,
-          key: 'bar',
-        },
-      ],
-      field: 'categories',
-      onlyOnType: SCThingType.AcademicEvent,
-    },
     {
       buckets: [
         {
@@ -153,7 +118,33 @@ describe('Aggregations', function () {
       field: 'categories',
       onlyOnType: SCThingType.Catalog,
     },
-    // no fooType as it doesn't appear in the aggregation schema
+    {
+      buckets: [
+        {
+          count: 8,
+          key: 'foobar',
+        },
+        {
+          count: 2,
+          key: 'bar',
+        },
+      ],
+      field: 'categories',
+      onlyOnType: SCThingType.AcademicEvent,
+    },
+    {
+      buckets: [
+        {
+          count: 13,
+          key: 'person',
+        },
+        {
+          count: 4,
+          key: 'catalog',
+        },
+      ],
+      field: 'type',
+    },
   ];
 
   it('should parse the aggregations providing the appropriate facets', function () {