refactor: adjust to new tslint settings

test/Guards.spec.ts

@@ -14,44 +14,129 @@
  */
 import {expect} from 'chai';
 import {slow, suite, test, timeout} from 'mocha-typescript';
+import {SCBulkResponse} from '../src/core/protocol/routes/bulk/BulkResponse';
+import {SCMultiSearchResponse} from '../src/core/protocol/routes/search/MultiSearchResponse';
+import {SCSearchResponse} from '../src/core/protocol/routes/search/SearchResponse';
 import {SCThingOriginType, SCThingType} from '../src/core/Thing';
 import {SCDish} from '../src/core/things/Dish';
-import {isThing} from '../src/core/types/Guards';
+import {
+  isBulkResponse,
+  isMultiSearchResponse,
+  isSearchResponse,
+  isThing,
+  isThingWithTranslations,
+} from '../src/core/types/Guards';
 
 @suite(timeout(10000), slow(5000))
 export class GuardsSpec {
+
+  static bulkResponse: SCBulkResponse = {
+    expiration: '2009-06-30T18:30:00+02:00 ',
+    source: 'bar',
+    state: 'done',
+    type: SCThingType.Dish,
+    uid: 'foo',
+  };
+
+  static dishWithTranslation: SCDish = {
+    categories: [
+      'appetizer',
+    ],
+    name: 'foo',
+    origin: {
+      created: '',
+      type: SCThingOriginType.User,
+    },
+    translations: {
+      de: {
+        name: 'Foo',
+      },
+    },
+    type: SCThingType.Dish,
+    uid: 'bar',
+  };
+
+  static notADish = {
+    categories: [
+      'appetizer',
+    ],
+    name: 'foo',
+    origin: {
+      created: '',
+      type: SCThingOriginType.User,
+    },
+    type: 'foobar',
+    uid: 'bar',
+  };
+
+  static searchResponse: SCSearchResponse = {
+    data: [
+      GuardsSpec.dishWithTranslation,
+    ],
+    facets: [
+      {
+       buckets: [
+         {
+          count: 1,
+          key: 'key',
+         },
+        ],
+       field: 'field',
+      },
+    ],
+    pagination: {
+      count: 1,
+      offset: 0,
+      total: 1,
+    },
+    stats: {
+      time: 1,
+    },
+  };
+
+  @test
+  public isBulkResponse() {
+    expect(isBulkResponse(null)).to.be.equal(false);
+    expect(isBulkResponse(GuardsSpec.dishWithTranslation)).to.be.equal(false);
+    expect(isBulkResponse(GuardsSpec.bulkResponse)).to.be.equal(true);
+  }
+
+  @test
+  public isMultiSearchResponse() {
+    const multiSearchResponse: SCMultiSearchResponse = {
+      foo: GuardsSpec.searchResponse,
+    };
+    expect(isMultiSearchResponse(multiSearchResponse)).to.be.equal(true);
+    const notAMultiSearchResponse = {...multiSearchResponse, ...{bar: 'baz'}};
+    expect(isMultiSearchResponse(notAMultiSearchResponse)).to.be.equal(false);
+    delete multiSearchResponse.foo;
+    expect(isMultiSearchResponse(multiSearchResponse)).to.be.equal(false);
+  }
+
+  @test
+  public isSearchResponse() {
+    const notASearchResponse = {...GuardsSpec.searchResponse};
+    delete notASearchResponse.pagination;
+    expect(isSearchResponse(notASearchResponse)).to.be.equal(false);
+    delete notASearchResponse.data;
+    expect(isSearchResponse(notASearchResponse)).to.be.equal(false);
+    expect(isSearchResponse(null)).to.be.equal(false);
+    expect(isSearchResponse(GuardsSpec.searchResponse)).to.be.equal(true);
+  }
+
   @test
   public isThing() {
-    const notADish = {
-      categories: [
-        'appetizer',
-      ],
-      name: 'foo',
-      origin: {
-        created: '',
-        type: SCThingOriginType.User,
-      },
-      type: 'foobar',
-      uid: 'bar',
-    };
-
-    const dish: SCDish = {
-      categories: [
-        'appetizer',
-      ],
-      name: 'foo',
-      origin: {
-        created: '',
-        type: SCThingOriginType.User,
-      },
-      type: SCThingType.Dish,
-      uid: 'bar',
-    };
-
     expect(isThing('foo')).to.be.equal(false);
+    expect(isThing({type: 'foo'})).to.be.equal(false);
+    expect(isThing(GuardsSpec.notADish)).to.be.equal(false);
+    expect(isThing(GuardsSpec.dishWithTranslation)).to.be.equal(true);
+  }
 
-    expect(isThing(notADish)).to.be.equal(false);
-
-    expect(isThing(dish)).to.be.equal(true);
+  @test
+  public isThingWithTranslations() {
+    const dishWithoutTranslation = {...GuardsSpec.dishWithTranslation};
+    delete dishWithoutTranslation.translations;
+    expect(isThingWithTranslations(dishWithoutTranslation)).to.be.equal(false);
+    expect(isThingWithTranslations(GuardsSpec.dishWithTranslation)).to.be.equal(true);
   }
 }

test/Translator.spec.ts

@@ -237,6 +237,7 @@ export class MetaTranslationSpec {
   public consistencyWithMetaClass() {
     const dishMetaTranslationsDE = translator.translatedPropertyNames(dish);
     const dishMetaTranslationsEN = translator.translatedPropertyNames(dish, 'en');
+    expect(dishMetaTranslationsEN).to.not.deep.equal(dishMetaTranslationsDE);
     expect(dishMetaTranslationsDE).to.deep.equal(SCDishMeta.getInstance().fieldTranslations.de);
     expect(dishMetaTranslationsEN).to.deep.equal(SCDishMeta.getInstance().fieldTranslations.en);
   }