refactor: split api into api, api-cli & api-plugin

frontend/app/.eslintrc.json

@@ -44,6 +44,7 @@
         ],
         "unicorn/no-nested-ternary": "off",
         "unicorn/better-regex": "off",
+        "unicorn/no-non-null-assertion": "off",
         "jsdoc/no-types": "error",
         "jsdoc/require-param": "off",
         "jsdoc/require-param-description": "error",

frontend/app/package.json

@@ -2,7 +2,6 @@
   "name": "@openstapps/app",
   "description": "The generic app tailored to fulfill needs of German universities, written using Ionic Framework.",
   "version": "2.1.0",
-  "type": "module",
   "license": "GPL-3.0-only",
   "author": "Karl-Philipp Wulfert <krlwlfrt@gmail.com>",
   "contributors": [
@@ -163,7 +162,7 @@
     "protractor": "7.0.0",
     "surge": "0.23.1",
     "ts-node": "10.9.1",
-    "typescript": "4.8.4",
+    "typescript": "4.6.4",
     "webpack-bundle-analyzer": "4.7.0"
   },
   "prettier": "@openstapps/prettier-config",

frontend/app/src/app/modules/catalog/catalog.component.ts

@@ -120,7 +120,7 @@ export class CatalogComponent implements OnInit, OnDestroy {
     this.availableSemesters = semesters
       .slice(Math.max(0, currentSemesterIndex - 1), Math.min(currentSemesterIndex + 2, semesters.length))
       .reverse();
-    if (typeof this.activeSemester !== 'undefined') {
+    if (this.activeSemester !== undefined) {
       return;
     }
 

frontend/app/src/app/modules/data/data.provider.spec.ts

@@ -14,7 +14,7 @@
  */
 /* eslint-disable @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-explicit-any, unicorn/no-thenable */
 import {TestBed} from '@angular/core/testing';
-import {Client} from '@openstapps/api/lib/client';
+import {Client} from '@openstapps/api';
 import {
   SCDish,
   SCMessage,

frontend/app/src/app/modules/hebis/daia-data.provider.ts

@@ -132,9 +132,7 @@ export class DaiaDataProvider {
                         signature: label,
                         status: holdingStatus,
                         dueDate: dueDate,
-                        online:
-                          Array.isArray(available) &&
-                          available.find(item => item.service === 'remote') !== undefined,
+                        online: Array.isArray(available) && available.some(item => item.service === 'remote'),
                         available:
                           (Array.isArray(available) &&
                             available.find(item =>