refactor: sort news by datePublished on backend

This commit is contained in:
Jovan Krunić
2021-07-06 17:16:55 +02:00
parent ccb851c0b5
commit 975f8e25e4
2 changed files with 18 additions and 31 deletions

View File

@@ -15,7 +15,6 @@
import {Injectable} from '@angular/core';
import {SCMessage} from '@openstapps/core';
import {DataProvider} from '../data/data.provider';
/**
* Service for providing news messages
*/
@@ -23,16 +22,15 @@ import {DataProvider} from '../data/data.provider';
providedIn: 'root',
})
export class NewsProvider {
constructor(private dataProvider: DataProvider) {}
constructor(private dataProvider: DataProvider) {
}
/**
* Get news messages
* TODO: make dates sortable on the backend side and then adjust this method
*
* @param size How many messages/news to fetch
* @param sort If sort by date needs to be performed
*/
async getList(size: number, sort?: boolean): Promise<SCMessage[]> {
async getList(size: number): Promise<SCMessage[]> {
const result = await this.dataProvider.search({
filter: {
type: 'value',
@@ -41,28 +39,16 @@ export class NewsProvider {
value: 'message',
},
},
sort: [{
type: 'generic',
arguments: {
field: 'datePublished',
},
order: 'desc',
}],
size: size,
});
const news = result.data as SCMessage[];
if (sort) {
news.sort((a, b) => {
if (
typeof a.datePublished !== 'undefined' &&
typeof b.datePublished !== 'undefined'
) {
return a.datePublished > b.datePublished
? -1
: a.datePublished < b.datePublished
? 1
: 0;
}
return 0;
});
}
return news;
return result.data as SCMessage[];
}
}