refactor(data): adjust data detail component

src/app/modules/data/detail/data-detail.component.spec.ts

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2018 StApps
+ * Copyright (C) 2018, 2019 StApps
  * This program is free software: you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by the Free
  * Software Foundation, version 3.
@@ -15,54 +15,98 @@
 import {CUSTOM_ELEMENTS_SCHEMA} from '@angular/core';
 import {async, ComponentFixture, TestBed} from '@angular/core/testing';
 import {ActivatedRoute, RouterModule} from '@angular/router';
+import {IonRefresher} from '@ionic/angular';
+import {SCMessage, SCThingOriginType, SCThingType} from '@openstapps/core';
 import {DataRoutingModule} from '../data-routing.module';
-import {DataListComponent} from '../list/data-list.component';
+import {DataModule} from '../data.module';
+import {DataProvider} from '../data.provider';
 import {DataDetailComponent} from './data-detail.component';
+import {TranslateModule, TranslateLoader, TranslateFakeLoader} from '@ngx-translate/core';
 
 describe('DataDetailComponent', () => {
   let comp: DataDetailComponent;
   let fixture: ComponentFixture<DataDetailComponent>;
   let detailPage: HTMLElement;
+  let dataProvider: DataProvider;
+  let refresher: IonRefresher;
 
   // @Component({ selector: 'stapps-data-list-item', template: '' })
   // class DataListItemComponent {
-  //   @Input() item;
-  // }
+    //   @Input() item;
+    // }
+
+  const sampleThing: SCMessage = {
+      audiences: ['students'],
+      message: 'Foo Message',
+      name: 'foo',
+      origin: {
+        indexed: 'SOME-DATE',
+      name: 'some name',
+      type: SCThingOriginType.Remote,
+    },
+    type: SCThingType.Message,
+    uid: '123',
+  };
 
   const fakeActivatedRoute = {
     snapshot: {
       paramMap: {
-        get: (url) => {
-          return url;
-        }
-      }
-    }
-  } as ActivatedRoute;
+        get: () => {
+          return sampleThing.uid;
+        },
+      },
+    },
+  };
 
   beforeEach(async(() => {
     TestBed.configureTestingModule({
-      declarations: [DataListComponent, DataDetailComponent],
-      imports: [RouterModule, DataRoutingModule],
+      imports: [RouterModule.forRoot([]), DataRoutingModule, DataModule,
+      TranslateModule.forRoot({
+        loader: {provide: TranslateLoader, useClass: TranslateFakeLoader},
+      })],
       providers: [{provide: ActivatedRoute, useValue: fakeActivatedRoute}],
       schemas: [CUSTOM_ELEMENTS_SCHEMA],
     })
-      .compileComponents();
+    .compileComponents();
   }));
 
-  beforeEach(async() => {
+  beforeEach(async () => {
+    dataProvider = TestBed.get(DataProvider);
+    refresher = jasmine.createSpyObj('refresher', ['complete']);
+    spyOn(dataProvider, 'get').and.returnValue(Promise.resolve(sampleThing));
+    spyOn(DataDetailComponent.prototype, 'getItem').and.callThrough();
     fixture = await TestBed.createComponent(DataDetailComponent);
     comp = fixture.componentInstance;
     fixture.detectChanges();
+    detailPage = fixture.nativeElement;
+    await dataProvider.deleteAll();
   });
 
   it('should create component', () =>
     expect(comp).toBeDefined(),
   );
 
-  it('should have apropriate title', () => {
-    detailPage = fixture.nativeElement;
+  it('should have apropriate title', async () => {
+    await fixture.whenStable();
     const title: HTMLIonTitleElement | null = detailPage.querySelector('ion-title');
     expect(title).not.toBe(null);
-    expect(title!.innerText).toContain('Detailansicht');
+    expect(title!.innerText).toContain('data.detail.TITLE');
+  });
+
+  it('should get a data item', () => {
+    comp.getItem(sampleThing.uid);
+    expect(DataDetailComponent.prototype.getItem).toHaveBeenCalledWith(sampleThing.uid);
+  });
+
+  it('should get a data item when component is accessed', async () => {
+    await fixture.whenStable();
+    expect(DataDetailComponent.prototype.getItem).toHaveBeenCalledWith(sampleThing.uid);
+  });
+
+  it('should update the data item when refresh is called', async () => {
+    await fixture.whenStable();
+    await comp.refresh(refresher);
+    expect(DataDetailComponent.prototype.getItem).toHaveBeenCalledWith(sampleThing.uid);
+    expect(refresher.complete).toHaveBeenCalled();
   });
 });