Theaninova/openstapps
1
0
Fork 0
mirror of https://gitlab.com/openstapps/openstapps.git synced 2026-01-21 17:12:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: avoid errors in daia availability UI

Browse Source
This commit is contained in:
Rainer Killinger
2022-02-08 13:03:21 +01:00
parent 988236e646
commit 6ce435fc05
5 changed files with 33 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/app/modules/hebis/daia-data.provider.ts
View File

@@ -51,7 +51,8 @@ export class DaiaDataProvider extends DataProvider {
* @param stAppsWebHttpClient TODO
* @param storageProvider TODO
* @param httpClient TODO
* @param ConfigProvider TODO
* @param configProvider TODO
* @param logger TODO
*/
constructor(
stAppsWebHttpClient: StAppsWebHttpClient,
@@ -71,7 +72,7 @@ export class DaiaDataProvider extends DataProvider {
);
}
async getAvailability(id: string): Promise<SCDaiaHoldings[]> {
async getAvailability(id: string): Promise<SCDaiaHoldings[] | undefined> {
if (this.backendUrl === environment.backend_url) {
try {
const features = (await this.configProvider.getValue(
@@ -81,11 +82,11 @@ export class DaiaDataProvider extends DataProvider {
this.backendUrl = features.extern?.daia?.url;
} else {
this.logger.error('Daia service url undefined');
return [];
return undefined;
}
} catch (error) {
this.logger.error(error);
return [];
return undefined;
}
}
return new Promise(resolve =>
@@ -143,7 +144,8 @@ export class DaiaDataProvider extends DataProvider {
},
error => {
this.logger.error(error);
resolve([]);
// eslint-disable-next-line unicorn/no-useless-undefined
resolve(undefined);
},
),
);