From 63a38e00771565c273d4eb87571f90839d5fd46a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thea=20Sch=C3=B6bl?= <dev@theaninova.de>
Date: Tue, 2 Jan 2024 13:23:59 +0100
Subject: [PATCH] feat: enable checkJs by default

---
 backend/backend/config/b-tu/elasticsearchrc.js            | 2 --
 backend/backend/config/default/app/language-setting.js    | 1 -
 backend/backend/config/default/app/menu.js                | 1 -
 backend/backend/config/default/app/user-group-setting.js  | 1 -
 backend/backend/config/default/backend/aggregations.js    | 1 -
 backend/backend/config/default/backend/boostings.js       | 1 -
 backend/backend/config/default/backend/index.js           | 1 -
 backend/backend/config/default/backendrc.js               | 1 -
 backend/backend/config/default/elasticsearchrc.js         | 2 --
 backend/backend/config/default/tools/markdown.js          | 1 -
 backend/backend/config/default/tools/semester-acronym.js  | 1 -
 backend/backend/config/default/tools/version.js           | 1 -
 backend/backend/config/f-u/about-pages/about.js           | 1 -
 backend/backend/config/f-u/about-pages/imprint.js         | 1 -
 backend/backend/config/f-u/about-pages/index.js           | 1 -
 backend/backend/config/f-u/about-pages/privacy.js         | 1 -
 backend/backend/config/f-u/backendrc.js                   | 1 -
 backend/backend/config/f-u/version-history/index.js       | 1 -
 configuration/eslint-config/copyright-header-rule.js      | 1 -
 configuration/eslint-config/copyright-header-rule.spec.js | 1 -
 configuration/eslint-config/index.js                      | 2 --
 configuration/tsconfig/tsconfig.json                      | 1 +
 frontend/app/karma.conf.js                                | 1 -
 packages/core-tools/src/schema.ts                         | 1 +
 24 files changed, 2 insertions(+), 25 deletions(-)

diff --git a/backend/backend/config/b-tu/elasticsearchrc.js b/backend/backend/config/b-tu/elasticsearchrc.js
index 062bc7f4..db469267 100644
--- a/backend/backend/config/b-tu/elasticsearchrc.js
+++ b/backend/backend/config/b-tu/elasticsearchrc.js
@@ -1,5 +1,3 @@
-// @ts-check
-
 /**
  * This is the database configuration for the technical university of berlin
  *
diff --git a/backend/backend/config/default/app/language-setting.js b/backend/backend/config/default/app/language-setting.js
index 7d82ea39..ebf40fa2 100644
--- a/backend/backend/config/default/app/language-setting.js
+++ b/backend/backend/config/default/app/language-setting.js
@@ -1,4 +1,3 @@
-// @ts-check
 import {SCSettingInputType, SCThingOriginType, SCThingType} from '@openstapps/core';
 
 /** @type {import('@openstapps/core').SCLanguageSetting}  */
diff --git a/backend/backend/config/default/app/menu.js b/backend/backend/config/default/app/menu.js
index 64595513..5ebcf609 100644
--- a/backend/backend/config/default/app/menu.js
+++ b/backend/backend/config/default/app/menu.js
@@ -1,4 +1,3 @@
-// @ts-check
 /** @type {import('@openstapps/core').SCAppConfigurationMenuCategory[]} */
 const menus = [
   {
diff --git a/backend/backend/config/default/app/user-group-setting.js b/backend/backend/config/default/app/user-group-setting.js
index 281197ef..62cbd687 100644
--- a/backend/backend/config/default/app/user-group-setting.js
+++ b/backend/backend/config/default/app/user-group-setting.js
@@ -1,4 +1,3 @@
-// @ts-check
 import {SCSettingInputType, SCThingOriginType, SCThingType} from '@openstapps/core';
 
 /** @type {import('@openstapps/core').SCUserGroupSetting} */
diff --git a/backend/backend/config/default/backend/aggregations.js b/backend/backend/config/default/backend/aggregations.js
index 5b60dfb5..89877de8 100644
--- a/backend/backend/config/default/backend/aggregations.js
+++ b/backend/backend/config/default/backend/aggregations.js
@@ -1,4 +1,3 @@
-// @ts-check
 import {SCThingType} from '@openstapps/core';
 
 /** @type {import('@openstapps/core').SCBackendAggregationConfiguration[]} */
diff --git a/backend/backend/config/default/backend/boostings.js b/backend/backend/config/default/backend/boostings.js
index abfae65d..e3d90b91 100644
--- a/backend/backend/config/default/backend/boostings.js
+++ b/backend/backend/config/default/backend/boostings.js
@@ -1,4 +1,3 @@
-// @ts-check
 import {
   month,
   sommerRange,
diff --git a/backend/backend/config/default/backend/index.js b/backend/backend/config/default/backend/index.js
index 8588f4d0..7e9a40d7 100644
--- a/backend/backend/config/default/backend/index.js
+++ b/backend/backend/config/default/backend/index.js
@@ -1,4 +1,3 @@
-// @ts-check
 import {SCThingType} from '@openstapps/core';
 import aggregations from './aggregations.js';
 import boostings from './boostings.js';
diff --git a/backend/backend/config/default/backendrc.js b/backend/backend/config/default/backendrc.js
index 9d2d20e5..f3ee9aa1 100644
--- a/backend/backend/config/default/backendrc.js
+++ b/backend/backend/config/default/backendrc.js
@@ -1,4 +1,3 @@
-// @ts-check
 import app from './app/index.js';
 import {backend, internal} from './backend/index.js';
 
diff --git a/backend/backend/config/default/elasticsearchrc.js b/backend/backend/config/default/elasticsearchrc.js
index 81e2cec2..9444a640 100644
--- a/backend/backend/config/default/elasticsearchrc.js
+++ b/backend/backend/config/default/elasticsearchrc.js
@@ -1,5 +1,3 @@
-// @ts-check
-
 /**
  * This is the default configuration for elasticsearch (a database)
  *
diff --git a/backend/backend/config/default/tools/markdown.js b/backend/backend/config/default/tools/markdown.js
index b5060cab..02506a16 100644
--- a/backend/backend/config/default/tools/markdown.js
+++ b/backend/backend/config/default/tools/markdown.js
@@ -1,4 +1,3 @@
-// @ts-check
 import {readFile} from 'fs/promises';
 import {SCAboutPageContentType} from '@openstapps/core';
 
diff --git a/backend/backend/config/default/tools/semester-acronym.js b/backend/backend/config/default/tools/semester-acronym.js
index 2d4d6c35..74801ffa 100644
--- a/backend/backend/config/default/tools/semester-acronym.js
+++ b/backend/backend/config/default/tools/semester-acronym.js
@@ -1,4 +1,3 @@
-// @ts-check
 /**
  * Generates a range of numbers that represent consecutive calendar months
  *
diff --git a/backend/backend/config/default/tools/version.js b/backend/backend/config/default/tools/version.js
index 997c0a9b..0662a5c0 100644
--- a/backend/backend/config/default/tools/version.js
+++ b/backend/backend/config/default/tools/version.js
@@ -1,4 +1,3 @@
-// @ts-check
 import {readFile, readdir} from 'fs/promises';
 import url from 'url';
 import path from 'path';
diff --git a/backend/backend/config/f-u/about-pages/about.js b/backend/backend/config/f-u/about-pages/about.js
index b79f5514..563ec8bc 100644
--- a/backend/backend/config/f-u/about-pages/about.js
+++ b/backend/backend/config/f-u/about-pages/about.js
@@ -1,4 +1,3 @@
-// @ts-check
 import {SCAboutPageContentType} from '@openstapps/core';
 import {markdown} from '../../default/tools/markdown.js';
 
diff --git a/backend/backend/config/f-u/about-pages/imprint.js b/backend/backend/config/f-u/about-pages/imprint.js
index 761f7717..b6984c13 100644
--- a/backend/backend/config/f-u/about-pages/imprint.js
+++ b/backend/backend/config/f-u/about-pages/imprint.js
@@ -1,4 +1,3 @@
-// @ts-check
 import {SCAboutPageContentType} from '@openstapps/core';
 
 /** @type {import('@openstapps/core').SCAboutPage} */
diff --git a/backend/backend/config/f-u/about-pages/index.js b/backend/backend/config/f-u/about-pages/index.js
index 311a70a3..1a407e50 100644
--- a/backend/backend/config/f-u/about-pages/index.js
+++ b/backend/backend/config/f-u/about-pages/index.js
@@ -1,4 +1,3 @@
-// @ts-check
 import about from './about.js';
 import imprint from './imprint.js';
 import privacy from './privacy.js';
diff --git a/backend/backend/config/f-u/about-pages/privacy.js b/backend/backend/config/f-u/about-pages/privacy.js
index 40ac0412..ea7b1107 100644
--- a/backend/backend/config/f-u/about-pages/privacy.js
+++ b/backend/backend/config/f-u/about-pages/privacy.js
@@ -1,4 +1,3 @@
-// @ts-check
 import {markdown} from '../../default/tools/markdown.js';
 
 /** @type {import('@openstapps/core').SCAboutPage} */
diff --git a/backend/backend/config/f-u/backendrc.js b/backend/backend/config/f-u/backendrc.js
index 24fce993..a16e0e72 100644
--- a/backend/backend/config/f-u/backendrc.js
+++ b/backend/backend/config/f-u/backendrc.js
@@ -1,4 +1,3 @@
-// @ts-check
 import aboutPages from './about-pages/index.js';
 import defaultApp from '../default/app/index.js';
 import {backend as defaultBackend, internal as defaultInternal} from '../default/backend/index.js';
diff --git a/backend/backend/config/f-u/version-history/index.js b/backend/backend/config/f-u/version-history/index.js
index 17c5b102..c13978d6 100644
--- a/backend/backend/config/f-u/version-history/index.js
+++ b/backend/backend/config/f-u/version-history/index.js
@@ -1,4 +1,3 @@
-// @ts-check
 import {versions} from '../../default/tools/version.js';
 
 /** @type {import('@openstapps/core').SCAppVersionInfo[]} */
diff --git a/configuration/eslint-config/copyright-header-rule.js b/configuration/eslint-config/copyright-header-rule.js
index 35330a2c..0eb6644a 100644
--- a/configuration/eslint-config/copyright-header-rule.js
+++ b/configuration/eslint-config/copyright-header-rule.js
@@ -1,4 +1,3 @@
-// @ts-check
 const fs = require("fs");
 const path = require("node:path");
 const child_process = require("child_process");
diff --git a/configuration/eslint-config/copyright-header-rule.spec.js b/configuration/eslint-config/copyright-header-rule.spec.js
index a28dae1e..5f605e48 100644
--- a/configuration/eslint-config/copyright-header-rule.spec.js
+++ b/configuration/eslint-config/copyright-header-rule.spec.js
@@ -1,4 +1,3 @@
-// @ts-check
 "use strict"
 
 const rule = require('./copyright-header-rule')
diff --git a/configuration/eslint-config/index.js b/configuration/eslint-config/index.js
index f19d8236..c87d6fe7 100644
--- a/configuration/eslint-config/index.js
+++ b/configuration/eslint-config/index.js
@@ -1,5 +1,3 @@
-// @ts-check
-
 /** @type {import('eslint').Linter.Config} */
 const config = {
   root: true,
diff --git a/configuration/tsconfig/tsconfig.json b/configuration/tsconfig/tsconfig.json
index 6800ead8..b261bf43 100644
--- a/configuration/tsconfig/tsconfig.json
+++ b/configuration/tsconfig/tsconfig.json
@@ -14,6 +14,7 @@
     "noFallthroughCasesInSwitch": true,
     "isolatedModules": true,
     "allowJs": true,
+    "checkJs": true,
     "resolveJsonModule": true,
     "allowSyntheticDefaultImports": true,
     "noImplicitAny": true,
diff --git a/frontend/app/karma.conf.js b/frontend/app/karma.conf.js
index e5fa2523..b2c65ca3 100644
--- a/frontend/app/karma.conf.js
+++ b/frontend/app/karma.conf.js
@@ -1,4 +1,3 @@
-// @ts-check
 /*
  * Copyright (C) 2022 StApps
  * This program is free software: you can redistribute it and/or modify it
diff --git a/packages/core-tools/src/schema.ts b/packages/core-tools/src/schema.ts
index 677eaf62..957716ac 100644
--- a/packages/core-tools/src/schema.ts
+++ b/packages/core-tools/src/schema.ts
@@ -52,6 +52,7 @@ export class Converter {
       path: sourcePath,
       sortProps: true,
       topRef: false,
+      skipTypeCheck: true,
       tsconfig: path.join(getTsconfigPath(projectPath), 'tsconfig.json'),
       type: 'SC',
     };