Theaninova/openstapps
1
0
Fork 0
mirror of https://gitlab.com/openstapps/openstapps.git synced 2026-01-04 20:42:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: omit assigne self reference

Browse Source
This commit is contained in:
Rainer Killinger
2020-10-30 17:18:31 +01:00
parent bc2b0ce136
commit 5f34bc900c
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/tasks/remind.ts
View File

@@ -115,6 +115,10 @@ export async function remind(api: Api): Promise<void> {
// get possible appropers, prefixed with '@' and joined with commas // get possible appropers, prefixed with '@' and joined with commas
const possibleApprovers = maintainerUsernames const possibleApprovers = maintainerUsernames
.filter((username) => { .filter((username) => {
if (mergeRequest.assignee.username === username) {
return false;
}
if (approval.approved_by.length === 0) { if (approval.approved_by.length === 0) {
return true; return true;
} }
@@ -133,8 +137,8 @@ export async function remind(api: Api): Promise<void> {
// send message to slack // send message to slack
await client.chat.postMessage({ await client.chat.postMessage({
channel: SLACK_CHANNEL, channel: SLACK_CHANNEL,
text: `Merge request '${mergeRequest.title}' needs more approvals! See ${mergeRequest.web_url}!`, text: `Merge request '${mergeRequest.title}' needs more approvals! See ${mergeRequest.web_url}!`,
}); });
// create note in merge request // create note in merge request
@@ -149,12 +153,15 @@ export async function remind(api: Api): Promise<void> {
// send message to slack // send message to slack
await client.chat.postMessage({ await client.chat.postMessage({
channel: SLACK_CHANNEL, channel: SLACK_CHANNEL,
text: `Merge request '${mergeRequest.title}' is ready to be merged! See ${mergeRequest.web_url}!`, text: `Merge request '${mergeRequest.title}' is ready to be merged! See ${mergeRequest.web_url}!`,
}); });
// prefix maintainers with '@' and join with commas // prefix maintainers with '@' and join with commas
const possibleMergers = maintainerUsernames const possibleMergers = maintainerUsernames
.filter((username) => {
return mergeRequest.assignee.username !== username;
})
.map((username) => `@${username}`) .map((username) => `@${username}`)
.join(', '); .join(', ');