From 4865f911d1e65d5500d82813b49a8bb8243c753b Mon Sep 17 00:00:00 2001 From: Rainer Killinger Date: Fri, 30 Oct 2020 16:34:28 +0100 Subject: [PATCH] refactor: utilize null coalescing --- src/translator.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/translator.ts b/src/translator.ts index becb0096..cced9b7a 100644 --- a/src/translator.ts +++ b/src/translator.ts @@ -224,9 +224,7 @@ export class SCThingTranslator { */ public translatedPropertyNames(type: SCThingType, language?: keyof SCTranslations): T | undefined { - const targetLanguage = (typeof language !== 'undefined') ? language : this.language; - - return this.getAllMetaFieldTranslations(type, targetLanguage) as T; + return this.getAllMetaFieldTranslations(type, language ?? this.language) as T; } /** @@ -246,7 +244,7 @@ export class SCThingTranslator { language?: keyof SCTranslations): string | undefined { const fieldTranslation = this.getMetaClassInstance(type).fieldValueTranslations[language ?? this.language]?.[field]; - return fieldTranslation?.[key ?? ''] ?? fieldTranslation ?? key; + return fieldTranslation?.[key ?? ''] ?? key ?? fieldTranslation; } /**