Theaninova/openstapps
1
0
Fork 0
mirror of https://gitlab.com/openstapps/openstapps.git synced 2026-01-11 12:12:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: throw an error when removing a non-existing plugin

Browse Source 
Related to #2
This commit is contained in:
Jovan Krunić
2019-07-05 15:25:42 +02:00
committed by Rainer Killinger
parent 992a0a6f2c
commit 3ea2c3b98d
3 changed files with 11 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/routes/plugin-register-route.spec.ts
View File

@@ -17,6 +17,7 @@ import {
SCPluginAdd,
SCPluginAlreadyRegisteredErrorResponse,
SCPluginRemove,
SCNotFoundErrorResponse,
} from '@openstapps/core';
import {should, use} from 'chai';
import {slow, timeout} from 'mocha-typescript';
@@ -94,17 +95,12 @@ export class PluginRegisterRouteSpec {
}
@test
async 'should return false when removing a plugin whose route doesn\'t exist'() {
async 'should throw a "not found" error when removing a plugin whose route doesn\'t exist'() {
// register one plugin
await pluginRegisterHandler(registerAddRequest, {});
const response = await pluginRegisterHandler({...registerRemoveRequest, route: '/not-foo'}, {});
return response.should.eql({success: false});
// TODO: use 404 response
// return pluginRegisterHandler({...registerRemoveRequest, route: '/bar'}, {})
// .should.eventually.be.rejectedWith('Resource not found')
// .and.be.an.instanceOf(SCNotFoundErrorResponse);
return pluginRegisterHandler({...registerRemoveRequest, route: '/not-foo'}, {})
.should.eventually.be.rejectedWith('Resource not found')
.and.be.an.instanceOf(SCNotFoundErrorResponse);
}
}