From 3a79d57c8d2a309995eb574fd76101537ab58be8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thea=20Sch=C3=B6bl?= <dev@theaninova.de>
Date: Thu, 5 Oct 2023 15:33:08 +0200
Subject: [PATCH] fix: detail view should not reuse things without references

---
 .../app/src/app/modules/data/detail/data-detail.component.ts | 5 +++++
 .../app/src/app/modules/data/list/search-page.component.ts   | 4 ----
 frontend/app/src/app/modules/map/position.service.ts         | 2 --
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/frontend/app/src/app/modules/data/detail/data-detail.component.ts b/frontend/app/src/app/modules/data/detail/data-detail.component.ts
index d64e98a2..a668a03e 100644
--- a/frontend/app/src/app/modules/data/detail/data-detail.component.ts
+++ b/frontend/app/src/app/modules/data/detail/data-detail.component.ts
@@ -93,6 +93,11 @@ export class DataDetailComponent implements OnInit {
     translateService: TranslateService,
   ) {
     this.inputItem = router.getCurrentNavigation()?.extras.state?.item;
+    if (!this.inputItem?.origin) {
+      // We received a ThingWithoutReferences.
+      // This can happen, for example, when detail views use `inPlace` list items
+      delete this.inputItem;
+    }
     this.language = translateService.currentLang as SCLanguageCode;
     translateService.onLangChange.subscribe((event: LangChangeEvent) => {
       this.language = event.lang as SCLanguageCode;
diff --git a/frontend/app/src/app/modules/data/list/search-page.component.ts b/frontend/app/src/app/modules/data/list/search-page.component.ts
index adfa8bab..90ff6d8b 100644
--- a/frontend/app/src/app/modules/data/list/search-page.component.ts
+++ b/frontend/app/src/app/modules/data/list/search-page.component.ts
@@ -228,10 +228,6 @@ export class SearchPageComponent implements OnInit {
         this.updateContextFilter(result.facets);
         this.items = Promise.resolve(result.data);
       }
-
-      this.items.then(it => {
-        if (it.length === result.pagination.total) console.log('final page loaded');
-      });
     } catch (error) {
       this.logger.error(error);
     } finally {
diff --git a/frontend/app/src/app/modules/map/position.service.ts b/frontend/app/src/app/modules/map/position.service.ts
index f29c96cd..53d36b1a 100644
--- a/frontend/app/src/app/modules/map/position.service.ts
+++ b/frontend/app/src/app/modules/map/position.service.ts
@@ -105,11 +105,9 @@ export class PositionService {
           subscriber.next(this.position);
         }
       });
-      watcherID.then(console.log);
       return {
         unsubscribe() {
           watcherID.then(id => {
-            console.log(id);
             void Geolocation.clearWatch({id});
           });
         },