fix: return validation error instead of internal server error

previously there was just a validation error inside an internal server error, which made no sense

src/routes/Route.ts

@@ -19,6 +19,7 @@ import {
   SCRoute,
   SCValidationErrorResponse,
 } from '@openstapps/core';
+import {Validator} from '@openstapps/core-tools/lib/validate';
 import {Application, Router} from 'express';
 import PromiseRouter from 'express-promise-router';
 import {ValidationError} from 'jsonschema';
@@ -70,6 +71,9 @@ export function createRoute<RETURNTYPE>(
     route[verb](async (req, res) => {
 
       try {
+        // get the core validator from the app
+        const validator: Validator = req.app.get('validator');
+
         // validate request
         const requestValidation = validator.validate(req.body, routeClass.requestBodyName);
 
@@ -95,13 +99,13 @@ export function createRoute<RETURNTYPE>(
             responseErrors,
             isTestEnvironment,
           );
-          const internalServerError = new SCInternalServerErrorResponse(
+          /*const internalServerError = new SCInternalServerErrorResponse(
             validationError,
-            isTestEnvironment,
+            req.app.get('isTestEnvironment'),
-          );
+          );*/
-          res.status(internalServerError.statusCode);
+          res.status(validationError.statusCode);
-          res.json(internalServerError);
+          res.json(validationError);
-          logger.warn(internalServerError);
+          logger.warn(validationError);
           return;
         }