From f9a63a87241408efdc4bb9d345765ae4f6d52bbd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thea=20Sch=C3=B6bl?= <dev@theaninova.de>
Date: Fri, 8 Dec 2023 22:55:33 +0100
Subject: [PATCH] fix: warn users if no device is connected

fix: can't backup without a device
---
 src/routes/Footer.svelte              | 29 ++++++++++++++++++++++-----
 src/routes/Navigation.svelte          | 16 +++++++--------
 src/routes/config/+layout.svelte      | 17 ----------------
 src/routes/config/layout/+page.svelte |  2 +-
 4 files changed, 32 insertions(+), 32 deletions(-)
 delete mode 100644 src/routes/config/+layout.svelte

diff --git a/src/routes/Footer.svelte b/src/routes/Footer.svelte
index ae838526..2993c967 100644
--- a/src/routes/Footer.svelte
+++ b/src/routes/Footer.svelte
@@ -8,6 +8,7 @@
   import {loadLocaleAsync} from "../i18n/i18n-util.async"
   import {tick} from "svelte"
   import SyncOverlay from "./SyncOverlay.svelte"
+  import {serialPort} from "$lib/serial/connection"
 
   let locale = (browser && (localStorage.getItem("locale") as Locales)) || detectLocale()
   $: if (browser)
@@ -46,9 +47,14 @@
       >
     </li>
   </ul>
-
-  <SyncOverlay />
-
+  <div>
+    {#if !$serialPort}
+      <div class="warning">
+        <span class="icon">warning</span>{$LL.deviceManager.NO_DEVICE()}
+      </div>
+    {/if}
+    <SyncOverlay />
+  </div>
   <ul>
     <li>
       <input use:action={{title: $LL.profile.theme.COLOR_SCHEME()}} type="color" bind:value={$theme.color} />
@@ -87,6 +93,14 @@
     opacity: 0;
   }
 
+  .warning {
+    color: var(--md-sys-color-error);
+    gap: 8px;
+    display: flex;
+    align-items: center;
+    justify-content: center;
+  }
+
   input[type="color"] {
     cursor: pointer;
 
@@ -116,9 +130,10 @@
   }
 
   footer {
-    display: flex;
+    display: grid;
     align-items: center;
-    justify-content: space-between;
+    justify-content: center;
+    grid-template-columns: 1fr auto 1fr;
 
     width: 100%;
     padding: 8px;
@@ -137,6 +152,10 @@
     padding: 0;
 
     list-style: none;
+
+    &:last-child {
+      justify-content: flex-end;
+    }
   }
 
   ul:last-child {
diff --git a/src/routes/Navigation.svelte b/src/routes/Navigation.svelte
index 39986b19..290e7098 100644
--- a/src/routes/Navigation.svelte
+++ b/src/routes/Navigation.svelte
@@ -50,15 +50,13 @@
         <PwaStatus />
       {/await}
     {/if}
-    {#if $serialPort}
-      <button use:action={{title: $LL.backup.TITLE()}} use:popup={BackupPopup} class="icon {$syncStatus}">
-        {#if $userPreferences.backup}
-          history
-        {:else}
-          history_toggle_off
-        {/if}
-      </button>
-    {/if}
+    <button use:action={{title: $LL.backup.TITLE()}} use:popup={BackupPopup} class="icon {$syncStatus}">
+      {#if $userPreferences.backup}
+        history
+      {:else}
+        history_toggle_off
+      {/if}
+    </button>
     <button
       bind:this={connectButton}
       use:action={{title: $LL.deviceManager.TITLE()}}
diff --git a/src/routes/config/+layout.svelte b/src/routes/config/+layout.svelte
deleted file mode 100644
index 7a851047..00000000
--- a/src/routes/config/+layout.svelte
+++ /dev/null
@@ -1,17 +0,0 @@
-<script>
-  import {serialPort} from "$lib/serial/connection"
-  import {LL} from "../../i18n/i18n-svelte"
-</script>
-
-{#if $serialPort}
-  <slot />
-{:else}
-  <p>{$LL.deviceManager.NO_DEVICE()}</p>
-{/if}
-
-<style lang="scss">
-  p {
-    margin: auto;
-    opacity: 0.4;
-  }
-</style>
diff --git a/src/routes/config/layout/+page.svelte b/src/routes/config/layout/+page.svelte
index 5e11d200..f7fa0c30 100644
--- a/src/routes/config/layout/+page.svelte
+++ b/src/routes/config/layout/+page.svelte
@@ -30,7 +30,7 @@
       onHidden(instance) {
         instance.destroy()
       },
-      onDestroy(instance) {
+      onDestroy() {
         shareComponent.$destroy()
       },
     }).show()