From a23af9ba9db21d90ccd172628c9ae29e4ffd2cdf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thea=20Sch=C3=B6bl?= <dev@theaninova.de>
Date: Sat, 6 Apr 2024 15:56:02 +0200
Subject: [PATCH] fix: lite rgb

---
 src/lib/setting.ts                      | 8 +++++---
 src/routes/config/settings/+page.svelte | 9 ++++++---
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/src/lib/setting.ts b/src/lib/setting.ts
index 5c2fde7e..bec60dec 100644
--- a/src/lib/setting.ts
+++ b/src/lib/setting.ts
@@ -9,7 +9,9 @@ export const setting: Action<
   { id, inverse, scale },
 ) {
   node.setAttribute("disabled", "");
-  const type = node.getAttribute("type") as "number" | "checkbox";
+  const type = node.getAttribute("type") as "number" | "checkbox" | "range";
+  const isNumeric =
+    type === "number" || type === "range" || node instanceof HTMLSelectElement;
   const min = node.hasAttribute("min")
     ? Number(node.getAttribute("min"))
     : undefined;
@@ -20,7 +22,7 @@ export const setting: Action<
   const unsubscribe = settings.subscribe(async (settings) => {
     if (id in settings) {
       const { value, isApplied } = settings[id]!;
-      if (type === "number" || node instanceof HTMLSelectElement) {
+      if (isNumeric) {
         node.value = (
           inverse !== undefined
             ? inverse / value
@@ -44,7 +46,7 @@ export const setting: Action<
 
   async function listener() {
     let value: number;
-    if (type === "number" || node instanceof HTMLSelectElement) {
+    if (isNumeric) {
       value = Number(node.value);
       if (Number.isNaN(value)) return;
       value = Math.floor(
diff --git a/src/routes/config/settings/+page.svelte b/src/routes/config/settings/+page.svelte
index 42bbf33b..f84524ef 100644
--- a/src/routes/config/settings/+page.svelte
+++ b/src/routes/config/settings/+page.svelte
@@ -253,11 +253,14 @@
 
     {#if $serialPort.device === "LITE"}
       <fieldset>
-        <legend><label><input type="checkbox" />RGB</label></legend>
+        <legend
+          ><label><input type="checkbox" use:setting={{ id: 0x84 }} />RGB</label
+          ></legend
+        >
         <label
           >Brightness<input
             use:setting={{ id: 0x81 }}
-            type="range"
+            type="number"
             min="0"
             max="50"
             step="1"
@@ -274,7 +277,7 @@
           <option value="9">Blue</option>
           <option value="10">Violet</option>
           <option value="11">Pink</option>
-          <option value="10">Multicolor</option>
+          <option value="13">Multicolor</option>
         </select>
       </fieldset>
     {/if}